suggestion mode UI #6523
Merged
suggestion mode UI #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "default": true | ||
| "cody.suggestions.mode": { | ||
| "type": "string", | ||
| "enum": ["autocomplete", "auto-edits (Experimental)", "off"], |
There was a problem hiding this comment.
Based on the recent thread where we decided to hide this from users who do not have access to the feature, do you think we should change this PR to use a quick pick menu or something else that can be dynamically updated based on feature flag values?
There was a problem hiding this comment.
Following up on slack here
There was a problem hiding this comment.
Hey @valerybugakov
I will add a pop-up to communicate to the user why they are not eligible as per slack discussion.
It would be much easier for me to do this in #6463 this PR instead of current one, because it would create conflict between the PRs when I rebase. Would that be okay ?
valerybugakov
approved these changes
Jan 7, 2025
hitesh-1997
added a commit
that referenced
this pull request
Jan 8, 2025
## Context Currently `auto-edits` is not reactive to config changes and hence requires vscode reloading. If the user doesn't reload vscode `auto-edits` suggestion doesn't do away because the `auto-edits` provider is not `disposed` on the config change. This results into: 1. If the user turns off the suggestion mode: they will keep on seeing the `auto-edits` suggestions. 2. If user switches from the `auto-edits` to `autocomplete` mode, they will see the suggestion from both `autocomplete` and `auto-edits`. 3. The PR makes `auto-edits` reactive to the `authStatus` and `config` change similar to `autocomplete`, so that `auto-edits` is reactive and destroyed/created on the config changes without reloading vscode. 4. Build on top of: #6523 Example image below: <img width="607" alt="image" src="https://github.com/user-attachments/assets/c87a06d6-063e-46f1-b87e-8ef9ba59f519" /> ## Test plan 1. Add the breakpoints at `dispose` function and `provideInlineCompletion` function for `autocomplete` and `auto-edits` and make sure they are disposed and created upon config changes without reloading vscode. 2. CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
auto-editsbeing a replacement ofautocomplete. Based on the suggestion The, PR adds adrop-downfor the users to choose between the "autocomplete", "auto-edits" and "Off".The PR deprecates the 2 earlier
configurations:cody.autocomplete.enabledcody.experimental.autoedits.enabledAnd introduces the
cody.suggestions.mode: 'autocomplete' | 'auto-edits' | 'off'for the users to choose from.Test plan
Green CI
Also tested the agent test cases with the new config. Agent takes the default values from
vscode/package.jsonwhich usesautocompleteas default for suggestion mode and it works.